Some comments added to English strings.xml #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/src/main/res/values/strings.xml
Outdated
| @@ -1,10 +1,10 @@ | |||
| <resources> | |||
| <resources> <!-- Translators, pay attention to this notes! --> | |||
There was a problem hiding this comment.
pay attention to this notes
hows about
pay attention to these notes
There was a problem hiding this comment.
You're right! Thanks for marking that!
There was a problem hiding this comment.
And Everything Else Looks Good.
MatthewTighe
approved these changes
Feb 5, 2019
MatthewTighe
pushed a commit
that referenced
this pull request
Aug 14, 2019
* Some comments added to English strings.txt * Update strings.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
I've added some comments so @corbinlc won't need to explain other translators what he has explained to me. Maybe you should add other comments!
Link to relevant issues
#500 #430 #494