Fix import error #10
Fix import error #10
Conversation
|
Fixes issue #9 |
| @@ -32,7 +32,7 @@ | |||
|
|
|||
There was a problem hiding this comment.
Remove this comment that is not useful anymore.
| @@ -32,7 +32,7 @@ | |||
|
|
|||
| # Temporarily import private function as advised by Sean Budd from NVAccess. | |||
| # A public API can be requested by add-on developers 2-3 month after 2022.3.3 release if no issue is found. | |||
| from winAPI.sessionTracking import _isLockScreenModeActive | |||
| from winAPI.sessionTracking import isLockScreenModeActive | |||
There was a problem hiding this comment.
Importing this new symbol, the add-on will not work with older versions of NVDA (including 2023.1).
Could you use a try/except statement?
Also add a comment to indicate the versions of NVDA, e.g.:
try
# For NVDA >= 2023.2
import publicSymbol
except Blablabla:
# For NVDA < 2023.1
import _privateSymbol
This allows me to easily clean code when modifying the compatibility range.
|
Hi Cyrille, please review and test latest changes, where I've tried to address your comments. |
|
|
||
| try | ||
| # For NVDA >= 2023.2 | ||
| from winAPI.sessionTracking import isLockScreenModeActive as isLockScreen |
There was a problem hiding this comment.
Could you just used the new symbol defined in NVDA's core without renaming? It's quite clear and easier to find in the code.
| from winAPI.sessionTracking import isLockScreenModeActive as isLockScreen | |
| from winAPI.sessionTracking import isLockScreenModeActive |
Of course, it should be renamed to isLockScreenModeActive in the except clause and in the rest of the code.
|
Hi Cyrille, should be done |
No description provided.