Skip to content

Commit

Permalink
fixes build warnings + other misc PR changes
Browse files Browse the repository at this point in the history
  • Loading branch information
elijahbenizzy committed Apr 24, 2024
1 parent d4a0432 commit 9b2e288
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
4 changes: 1 addition & 3 deletions docs/concepts/ui.rst
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,7 @@ This will do the following:
3. Start the backend server
4. Start the frontend server

This takes a bit of time! So be patient. The server will be running on port 8242 -- in the logs you'll see something like this:

Then navigate to ``http://localhost:8242`` in your browser, and enter your email (this will be the username used within the app).
This takes a bit of time! So be patient. The server will be running on port 8242. Then navigate to ``http://localhost:8242`` in your browser, and enter your email (this will be the username used within the app).

Building the Docker Images locally
__________________________________
Expand Down
6 changes: 3 additions & 3 deletions ui/frontend/src/components/common/Dropdown.tsx
Original file line number Diff line number Diff line change
@@ -1,21 +1,21 @@
import { Listbox, Transition } from "@headlessui/react";
import { CheckIcon, ChevronUpDownIcon } from "@heroicons/react/20/solid";
import React, { Fragment } from "react";
import { AiFillQuestionCircle } from "react-icons/ai";
import { IconType } from "react-icons/lib";
import { classNames } from "../../utils";
import { HelpTooltip } from "./HelpTooltip";

type Selectable = {
name: string;
// eslint-disable-next-line
value: any;
icon?: IconType;
};

export const DropdownSelector: React.FC<{
choices: Selectable[];
setCurrentChoice: (choice: any) => void;
currentChoice: any | null;
setCurrentChoice: (choice: Selectable) => void;
currentChoice: Selectable | null;
title: string;
description?: string;
}> = (props) => {
Expand Down
8 changes: 5 additions & 3 deletions ui/frontend/src/components/dashboard/Project/Projects.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ export const ProjectCreateOrEditForm = (props: ProjectCreateFormProps) => {
? "Project description is required"
: undefined,
selectedWriteSharingEntities.length === 0
? "Write access is required by at least one user/team"
? "Write access is required by at least one user (or team, if using the enterprise version)"
: undefined,
].filter((item) => item !== undefined);

Expand Down Expand Up @@ -288,7 +288,8 @@ export const ProjectCreateOrEditForm = (props: ProjectCreateFormProps) => {
Read Access
</label>
<p className="mt-1 text-sm leading-6 text-gray-600 w-full">
Enter emails or select teams you are a part of.
Enter emails
{localMode ? " (reach out if you want team/organization-level ACLs)" : " or select teams you are part of."}.
</p>
<div className="mt-2">
<CreatableSelect
Expand Down Expand Up @@ -337,7 +338,8 @@ export const ProjectCreateOrEditForm = (props: ProjectCreateFormProps) => {
Write Access
</label>
<p className="mt-1 text-sm leading-6 text-gray-600 w-full">
Enter emails or select teams you are a part of.
Enter emails
{localMode ? " (reach out if you want team/organization-level ACLs)" : " or select teams you are part of."}.
</p>
<div className="mt-2">
<CreatableSelect
Expand Down

0 comments on commit 9b2e288

Please sign in to comment.