added check for default_factory (#1149)

* added check for default_factory

* moved the check up to AdapterCommon

* removed comment

---------

Co-authored-by: zilto <tjean@DESKTOP-V6JDCS2>

hamilton/io/data_adapters.py

@@ -72,7 +72,7 @@ def get_required_arguments(cls) -> Dict[str, Type[Type]]:
         return {
             field.name: type_hints.get(field.name)
             for field in dataclasses.fields(cls)
-            if field.default == dataclasses.MISSING
+            if field.default == dataclasses.MISSING and field.default_factory == dataclasses.MISSING
         }
 
     @classmethod
@@ -87,7 +87,7 @@ def get_optional_arguments(cls) -> Dict[str, Type[Type]]:
         return {
             field.name: type_hints.get(field.name)
             for field in dataclasses.fields(cls)
-            if field.default != dataclasses.MISSING
+            if field.default != dataclasses.MISSING or field.default_factory != dataclasses.MISSING
         }
 
     @classmethod

tests/function_modifiers/test_adapters.py

@@ -545,6 +545,70 @@ def fn() -> dict:
     assert list(saver_node.input_types) == ["fn"]
 
 
+@dataclasses.dataclass
+class DefaultFactoryLoader(DataLoader):
+    field_with_factory: int = dataclasses.field(default_factory=int)
+
+    def __post_init__(self):
+        self.param2 = self.field_with_factory + 1
+
+    def load_data(self, type_: Type[int]) -> Tuple[int, Dict[str, Any]]:
+        return self.param2, {}
+
+    @classmethod
+    def applicable_types(cls) -> Collection[Type]:
+        return [int]
+
+    @classmethod
+    def name(cls) -> str:
+        return "factory"
+
+
+def test_loader_default_factory_field():
+    @LoadFromDecorator([DefaultFactoryLoader])
+    def foo(param: int) -> int:
+        return param
+
+    fg = graph.create_function_graph(
+        ad_hoc_utils.create_temporary_module(foo),
+        config={},
+    )
+    assert len(fg) == 3
+    assert "foo" in fg
+
+
+@dataclasses.dataclass
+class DefaultFactorySaver(DataSaver):
+    field_with_factory: int = dataclasses.field(default_factory=int)
+
+    def __post_init__(self):
+        self.param2 = self.field_with_factory + 1
+
+    def save_data(self, data: int) -> Dict[str, Any]:
+        return {}
+
+    @classmethod
+    def applicable_types(cls) -> Collection[Type]:
+        return [int]
+
+    @classmethod
+    def name(cls) -> str:
+        return "factory"
+
+
+def test_saver_default_factory_field():
+    @SaveToDecorator([DefaultFactorySaver])
+    def foo(param: int) -> int:
+        return param
+
+    fg = graph.create_function_graph(
+        ad_hoc_utils.create_temporary_module(foo),
+        config={},
+    )
+    assert len(fg) == 3
+    assert "foo" in fg
+
+
 @dataclasses.dataclass
 class OptionalParamDataLoader(DataLoader):
     param: int = 1