Sdk extra guard #1157
Merged
Sdk extra guard #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't want to impact running code so we should just blanket catch everything on a best effort basis. Fixes #1156.
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 53e7045 in 22 seconds
More details
- Looked at
32lines of code in2files - Skipped
0files when reviewing. - Skipped posting
3drafted comments based on config settings.
1. ui/sdk/src/hamilton_sdk/driver.py:167
- Draft comment:
Catching a generalExceptionhere ensures robustness but might hide specific issues. Consider logging the exception for better debugging. - Reason this comment was not posted:
Confidence changes required:50%
The PR aims to catch more exceptions when retrieving git information. The changes replace specific exceptions with a generalExceptioncatch. This is a valid approach to ensure robustness, but it might hide specific issues that could be useful for debugging. However, given the context of the issue, this change aligns with the intent to prevent breaking due to uncaught exceptions.
2. ui/sdk/src/hamilton_sdk/driver.py:171
- Draft comment:
Catching a generalExceptionhere ensures robustness but might hide specific issues. Consider logging the exception for better debugging. - Reason this comment was not posted:
Confidence changes required:50%
The PR aims to catch more exceptions when retrieving git information. The changes replace specific exceptions with a generalExceptioncatch. This is a valid approach to ensure robustness, but it might hide specific issues that could be useful for debugging. However, given the context of the issue, this change aligns with the intent to prevent breaking due to uncaught exceptions.
3. ui/sdk/src/hamilton_sdk/driver.py:175
- Draft comment:
Catching a generalExceptionhere ensures robustness but might hide specific issues. Consider logging the exception for better debugging. - Reason this comment was not posted:
Confidence changes required:50%
The PR aims to catch more exceptions when retrieving git information. The changes replace specific exceptions with a generalExceptioncatch. This is a valid approach to ensure robustness, but it might hide specific issues that could be useful for debugging. However, given the context of the issue, this change aligns with the intent to prevent breaking due to uncaught exceptions.
Workflow ID: wflow_QrcBGt5U9KDRwbEO
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
|
pip install sf-hamilton-sdk==0.7.3rc0 |
zilto
reviewed
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1156
Changes
How I tested this
Notes
Checklist