Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sdk extra guard #1157

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Sdk extra guard #1157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e323947
Catches all exceptions when checking git related things
skrawcz Sep 25, 2024
53e7045
Bumps SDK to 0.7.3
skrawcz Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/sdk/src/hamilton_sdk/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = (0, 7, 2)
__version__ = (0, 7, 3)
6 changes: 3 additions & 3 deletions ui/sdk/src/hamilton_sdk/driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,16 +163,16 @@ def _derive_version_control_info(module_hash: str) -> GitInfo:

try:
commit = repo.head.commit
except ValueError:
except Exception:
skrawcz marked this conversation as resolved.
Show resolved Hide resolved
skrawcz marked this conversation as resolved.
Show resolved Hide resolved
return default
try:
repo_url = repo.remote().url
except ValueError:
except Exception:
# TODO: change this to point to our docs on what to do.
repo_url = "Error: No repository to link to."
try:
branch_name = repo.active_branch.name
except TypeError:
except Exception:
branch_name = "unknown" # detached head
logger.warning(
"Warning: we are unable to determine the branch name. "
Expand Down
Loading