Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors docker compose file setup #1061

Closed
wants to merge 1 commit into from
Closed

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Jul 23, 2024

This structure more naturally fits what docker expects. A docker-compose file at the root, with docker files for the respective services in those modules.

I have tested this locally for the prod build
and pushed things and I believe it works for
the other cases too.

TODO:

  • dockerx build instructions
  • automating the build & versioning of images with new releases

Changes

  • move docker files around

How I tested this

  • locally

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@skrawcz
Copy link
Collaborator Author

skrawcz commented Jul 23, 2024

@flavour thoughts?

This structure more naturally fits what docker expects.
A docker-compose file at the root, with docker files
for the respective services in those modules.

I have tested this locally for the prod build
and pushed things and I believe it works for
the other cases too.

TODO:
 - dockerx build instructions
 - automating the build & versioning of images with new releases
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant