Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix when using HamiltonTracker with polars dataframes #1126

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Bug fix when using HamiltonTracker with polars dataframes #1126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5bf20b2
Fix polars_col_stats.py
elyase Sep 8, 2024
9424fd1
add test for hamilton_sdk.tracking.polars_col_stats.str_len
elyase Sep 10, 2024
3cb0706
pre-commit cleanups
elyase Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/sdk/src/hamilton_sdk/tracking/polars_col_stats.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ def datetime_column_stats(


def str_len(col: pl.Series) -> pl.Series:
return col.str.lengths()
return col.str.len_chars()


def avg_str_len(str_len: pl.Series) -> float:
Expand Down
4 changes: 4 additions & 0 deletions ui/sdk/tests/tracking/test_polars_col_stats.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,3 +108,7 @@ def test_min_string(example_df_string):

def test_max_string(example_df_string):
assert pcs.max(example_df_string["a"]) == "e"


def test_str_len(example_df_string):
assert pcs.str_len(example_df_string["a"]).to_list() == [1, 1, 1, 1, 1]
Loading