Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date summary polars #1146

Merged
merged 6 commits into from
Sep 19, 2024
Merged

Fix date summary polars #1146

merged 6 commits into from
Sep 19, 2024

Conversation

skrawcz
Copy link
Collaborator

@skrawcz skrawcz commented Sep 19, 2024

Fixes a few polars things

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

skrawcz and others added 5 commits September 18, 2024 22:00
Didn't have appropriate test coverage, now we do.
If they're empty it breaks the UI.
So it's more up to date to use.
To push out polars fix.
Copy link
Collaborator

@elijahbenizzy elijahbenizzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, we're hardcoding std to 0 but that's OK Fixing tests

Not needed -- doesn't make sense for dates with polars.
@elijahbenizzy elijahbenizzy merged commit fa049fb into main Sep 19, 2024
24 of 30 checks passed
@elijahbenizzy elijahbenizzy deleted the fix_date_summary_polars branch September 19, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants