Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: added notebook to the scikit-learn example #463

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

flaviassantos
Copy link
Contributor

This PR is in response to #247.

Changes

A Jupyter notebook Hamilton for ML dataflows.ipynb was added to the repo.

How I tested this

I ran all cells successfully and ran pre-commit check.

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Copy link
Collaborator

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🇮🇹 ! ❤️

@skrawcz skrawcz merged commit a0f8d43 into DAGWorks-Inc:main Oct 15, 2023
2 checks passed
@DAGWorks-Inc DAGWorks-Inc deleted a comment from sweep-ai bot Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants