Support JSON output from Dataverse V6.2 plus retention period feature #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DD-1565
And to be more specific; Publish of a Dataset will fail on 6.2 without this fix.
Description of changes
Support JSON output from Dataverse V6.2 plus retention period feature
Part of upgrading our Data Stations to version 6.2 with added patches (epic DD-1547).
How to test
Build this and the build a local version of
dd-vault-metadata
that uses this newer lib.This will result in
0.27.1-SNAPSHOT
.Use that SNAPSHOT of the locally built client lib in
dd-vault-metadata
,dd-validate-dans-bag
anddd-ingest-flow
.Note: when building the client-lib now it produces version
0.27.1-SNAPSHOT
, but after releasing it will be0.28.0
.To test the backwards compatibility use a vagrant box that has our 6.0 version of datavesre;
start-preprovisioned-box.py -s
will give a working dev_archaeology basebox.Build the
dd-vault-metadata
,dd-validate-dans-bag
anddd-ingest-flow
services with that new client lib.Then deploy them on the vagrant box with
deploy.py -m <service name here> dev_archaeology
.The client lib (and the
dd-vault-metadata
service that uses it should be backwards compatible, we should test it by verifying that Publish also works on the Dataverse 6.0 that we have running now (also the DANS fork on our vagrant boxes).Testing the updated services can be done by running a SWORD2 example:
The PR on
dans-core-systems
below explains how you can have Dataverse 6.2 on the vagrant box. Initially it is fine to test with the IQSS version of 6.2, without the RetentionPeriod feature.After you make sure the Publish works, you can go on and install the DANS patched version that has support for the RetentionPeriod feature. In this case add a retention period to a file and then Publish the Datasset.
Related PRs
(Add links)
*https://github.com/DANS-KNAW/dans-core-systems/pull/30
*IQSS/dataverse#10336
Notify
@DANS-KNAW/core-systems