Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 13, 2022

Bumps github.com/fsnotify/fsnotify from 1.5.4 to 1.6.0.

Release notes

Sourced from github.com/fsnotify/fsnotify's releases.

v1.6.0

This version of fsnotify needs Go 1.16 (this was already the case since 1.5.1, but not documented). It also increases the minimum Linux version to 2.6.32.

Additions

  • all: add Event.Has() and Op.Has() (#477)

    This makes checking events a lot easier; for example:

    if event.Op&Write == Write && !(event.Op&Remove == Remove) {
    }
    

    Becomes:

    if event.Has(Write) && !event.Has(Remove) {
    }
    
  • all: add cmd/fsnotify (#463)

    A command-line utility for testing and some examples.

Changes and fixes

  • inotify: don't ignore events for files that don't exist (#260, #470)

    Previously the inotify watcher would call os.Lstat() to check if a file still exists before emitting events.

    This was inconsistent with other platforms and resulted in inconsistent event reporting (e.g. when a file is quickly removed and re-created), and generally a source of confusion. It was added in 2013 to fix a memory leak that no longer exists.

  • all: return ErrNonExistentWatch when Remove() is called on a path that's not watched (#460)

  • inotify: replace epoll() with non-blocking inotify (#434)

    Non-blocking inotify was not generally available at the time this library was written in 2014, but now it is. As a result, the minimum Linux version is bumped from 2.6.27 to 2.6.32. This hugely simplifies the code and is faster.

  • kqueue: don't check for events every 100ms (#480)

    The watcher would wake up every 100ms, even when there was nothing to do. Now it waits until there is something to do.

  • macos: retry opening files on EINTR (#475)

  • kqueue: skip unreadable files (#479)

    kqueue requires a file descriptor for every file in a directory; this would fail if a file was unreadable by the current user. Now these files are simply skipped.

  • windows: fix renaming a watched directory if the parent is also watched (#370)

  • windows: increase buffer size from 4K to 64K (#485)

... (truncated)

Changelog

Sourced from github.com/fsnotify/fsnotify's changelog.

[1.6.0] - 2022-10-13

This version of fsnotify needs Go 1.16 (this was already the case since 1.5.1, but not documented). It also increases the minimum Linux version to 2.6.32.

Additions

  • all: add Event.Has() and Op.Has() (#477)

    This makes checking events a lot easier; for example:

    if event.Op&Write == Write && !(event.Op&Remove == Remove) {
    }
    

    Becomes:

    if event.Has(Write) && !event.Has(Remove) {
    }
    
  • all: add cmd/fsnotify (#463)

    A command-line utility for testing and some examples.

Changes and fixes

  • inotify: don't ignore events for files that don't exist (#260, #470)

    Previously the inotify watcher would call os.Lstat() to check if a file still exists before emitting events.

    This was inconsistent with other platforms and resulted in inconsistent event reporting (e.g. when a file is quickly removed and re-created), and generally a source of confusion. It was added in 2013 to fix a memory leak that no longer exists.

  • all: return ErrNonExistentWatch when Remove() is called on a path that's not watched (#460)

  • inotify: replace epoll() with non-blocking inotify (#434)

    Non-blocking inotify was not generally available at the time this library was written in 2014, but now it is. As a result, the minimum Linux version is bumped from 2.6.27 to 2.6.32. This hugely simplifies the code and is faster.

  • kqueue: don't check for events every 100ms (#480)

    The watcher would wake up every 100ms, even when there was nothing to do. Now it waits until there is something to do.

  • macos: retry opening files on EINTR (#475)

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependency-update Update to build or runtime dependencies go Pull requests that update Go code labels Oct 13, 2022
@dependabot dependabot bot requested a review from a team October 13, 2022 04:07
@coveralls
Copy link

coveralls commented Oct 13, 2022

Pull Request Test Coverage Report for Build 4463246970

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.368%

Totals Coverage Status
Change from base Build 4463245017: 0.0%
Covered Lines: 1730
Relevant Lines: 1741

💛 - Coveralls

Bumps [github.com/fsnotify/fsnotify](https://github.com/fsnotify/fsnotify) from 1.5.4 to 1.6.0.
- [Release notes](https://github.com/fsnotify/fsnotify/releases)
- [Changelog](https://github.com/fsnotify/fsnotify/blob/main/CHANGELOG.md)
- [Commits](fsnotify/fsnotify@v1.5.4...v1.6.0)

---
updated-dependencies:
- dependency-name: github.com/fsnotify/fsnotify
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/src/github.com/fsnotify/fsnotify-1.6.0 branch from 7bac096 to d671ccd Compare March 19, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependency-update Update to build or runtime dependencies go Pull requests that update Go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants