Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support loading custom legend files #41

Open
jcfr opened this issue Jun 11, 2020 · 2 comments
Open

Support loading custom legend files #41

jcfr opened this issue Jun 11, 2020 · 2 comments
Assignees
Labels
Q3DC Related to the Q3DC module

Comments

@jcfr
Copy link
Contributor

jcfr commented Jun 11, 2020

Remove custom table management:

  • Support for direct loading of CSV file into Slicer. Once a file is loaded, this would create a vtkMRMLTableNode
  • Re-use the node selector associated with vtkMRMLTableNode.
  • Add "Import legend" button to the UI. Once the table node is imported it would be associated with an attribute like Q3DC.TableLegend ensuring only the relevant node are listed in the selector

Approach 1

  • Keep the current CSV format with the region, and implement filtering of table value per-region

Approach 2

  • Change the "legend" format so that we have one file per "region".

Instead of one file called base_fiducial_legend.csv, we would have the following files:

  • CRANIAL BASE.csv:
Region,Landmark,Name
CRANIAL BASE,Ba,Basion
CRANIAL BASE,S,Sella
CRANIAL BASE,N,Nasion
  • NASOMAXILLARY COMPLEX.csv:
NASOMAXILLARY COMPLEX,A,A-point
NASOMAXILLARY COMPLEX,ANS,Anterior Nasal Spine
[...]
  • MANDIBLE.csv:
MANDIBLE,B,B-point
MANDIBLE,Pog,Pogonion
[...]

cc: @aruellas

@bpaniagua
Copy link
Contributor

Approach #1 was selected during our last meeting.

JEHoctor added a commit to JEHoctor/Q3DCExtension that referenced this issue Jul 12, 2020
jcfr pushed a commit that referenced this issue Jul 13, 2020
ENH: Add 'Select Legend File' button

This commit addresses issue #41
@luciacev
Copy link
Contributor

luciacev commented Aug 8, 2020

@bpaniagua @jcfr
Thanks for your work on this open issue.
Nothing happens when I click on the Select legend button, No menu open. I tired to drag and drop a csv file with landmark legend but the select legend button does not seem to work. Thanks
Lucia

@allemangD allemangD added the Q3DC Related to the Q3DC module label Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Q3DC Related to the Q3DC module
Projects
None yet
Development

No branches or pull requests

5 participants