fix(global search bar): display result data with embedded search bar #1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dchiller
added a commit
to dchiller/CantusDB
that referenced
this pull request
Nov 21, 2024
Follow DDMAL#1712 and conform pagination styling of the browse chants templates to other filterable table templates.
Create two new extendable templates for two common use cases with an embedded search bar: one more generally for the embedded search bar and one for views that display filterable tables. Adjust all current views to use these templates where relevant. Put the search bar in a bootstrap column so that dynamic search result previews fill the correct horizontal space. Refs: DDMAL#1703
dchiller
force-pushed
the
i1703-global-search-bar-results
branch
from
892cc3c to
0561179
Compare
dchiller
added a commit
to dchiller/CantusDB
that referenced
this pull request
Dec 3, 2024
Follow DDMAL#1712 and conform pagination styling of the browse chants templates to other filterable table templates.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create two new extendable templates (
single_column_with_search_bar.htmlandfilterable_table_with_search_bar.html) for two common use cases with an embedded search bar: one more generally for the embedded search bar and one for views that display filterable tables.Adjust all current views to use these templates where relevant.
Put the search bar in a bootstrap column so that dynamic search result previews fill the correct horizontal space.
Closes #1703
Old look of the Genre list page while using the global search bar
New look of the Genre list page while using global search bar