-
Notifications
You must be signed in to change notification settings - Fork 2
Production Update (version...?) #357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: remove Google Tag installation & add GTM
- create url paths for view functions refs: #206
- deal with alias through InstrumentName column - delete InstrumentAlias object refs: #206
- add status field (verified, unverified, uploaded): differentiates new data, verified data and data that already exists on wikidata - contributor field: indicates user that added the InstrumentName refs: #206
- create very basic front end form to enter new instrument name object - testing data entry workflow - instruments/add-name refs: #206
- set uploaded names from database as "uploaded" - set publihs/ url as backend endpoint that receives a request and runs the logic to publish instrument names to wikidata
- create boolean fields for is_approved and on_wikidata - adjust edit-wikidata view to show approved, not on wikidata instrument names - change "viewer" group to "reviewer" refs: #240
- with the use of a modal, name adding is no longer on a new page - define form, languages and instrument name in active language contexts refs:#245
- modal allows user to enter new instrument name of choice refs: #245
- from branch img-upload/ add-UMIL-data refs: #245
- add confirmation modal - read in user input using javascript instead of a model form - remove model form refs: #245
- aligns with terminology refs: #245
- set alias/label status based on existing instrument on UMILdb refs: #245
fix: assign default contributor
…verification_status` refs: #334
- rename column to `Status` - implement feature for stacked layout refs: #334
- modal is triggered by an information icon - table in modal describes the meaning of each status for UMIL user refs:#334
- only display "under review" status on frontend for both under/needs additional review refs: #334
- hide status column from viewers - only display verified entries to viewers - contributors see their own entries and other verified entries with status column - superusers see all names and status refs: #334
- reduce redundant SQL queries Co-authored-by: Dylan Hillerbrand <dhillerbrand@gmail.com>
- add `needs_additional_review` as `verification_status` option refs:#334
feat: verification status column on instrument detail page refs: #334
- Related to this commit: - `main` branch - PROXY_HOST_PROD secret - HOST_PROD secret - `cd_prod.yml` file - What this GitHub Action does (it needs manual trigger by the way) - Change directory to `/virtual_instrument_museum` - Stop the containers - Fetch new updates from remote `origin` and log current branches - Checkout to `main` branch and pull new changes - Build Docker images, without cache - Compose up all services, including the new changes
Update Staging CD to build Docker with no cache and some minor formatting update
style: keep image aspect ratio in std view
style: set min height for content container
Merging un-rebase changes from develop branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.