Skip to content

Conversation

@PouyaMohseni
Copy link
Contributor

@PouyaMohseni PouyaMohseni commented Nov 15, 2025

resolves #423, resolves #420

Logged in:
Ex1
Ex2

Logged out:
Screenshot 2025-12-11 at 6 07 30 PM
Screenshot 2025-12-11 at 6 07 00 PM

@yinanazhou
Copy link
Member

A few tips for making PRs easier to review:

  • Concise commit title that summarizes the changes
  • Descriptive commit body about what is done
  • Reference the issue in the footer in the commit message
  • Screenshots that show the before&after if necessary

@yinanazhou
Copy link
Member

Instead of listing the alias in separate entire row as implemented, nested rows inside the alias cell would make more sense.

image

@PouyaMohseni
Copy link
Contributor Author

Instead of listing the alias in separate entire row as implemented, nested rows inside the alias cell would make more sense.

Like this? I believe it makes scrolling harder and also creates a lot of blank space, which makes the last three columns, which are relevant for any alias, feel unused. I tried removing stripes and removing some of the borders of the rows to make it clearer that aliases share the first three columns with the main label, but I couldn't get it to look straightforward.
Screenshot 2025-11-18 at 1 15 25 PM

@yinanazhou
Copy link
Member

You can try to use three columns for alias instead of three rows. You may also need to consider the ordering of the columns because now the last source column looks confusing

@PouyaMohseni
Copy link
Contributor Author

The source is not the last column; There are verification and action columns for a logged-in user, three of these are shared with aliases:

Screenshot 2025-11-18 at 1 51 00 PM

@yinanazhou
Copy link
Member

I meant the last column in the screenshot

@PouyaMohseni
Copy link
Contributor Author

Yes, but should I consider reordering all of these 3 columns? Thank you,

@PouyaMohseni
Copy link
Contributor Author

It is also expected to have a contributor column (#344), which is also relevant to aliases.

@yinanazhou
Copy link
Member

Please convert this to draft if not ready for review.

@PouyaMohseni PouyaMohseni marked this pull request as draft November 27, 2025 17:38
@PouyaMohseni
Copy link
Contributor Author

While we are discussing having a separate page for each instrument name, I propose the following structure for the Instrument Detail and Instrument Name Detail pages:


Instrument Detail Page

  • Information about the instrument
  • A table of instrument names with the following columns:
    • Language
    • Name
    • Alias (displayed as a nested under each entry)
    • Action (contains a More button)
    • Verification status, shown next to each label (name or alias)

Instrument Name Detail Page

  • Information about the instrument
  • Information about the selected name entry
  • An action button to Delete the instrument name
  • A table of visible sources, including:
    • Source
    • Reviewe
    • Action (e.g., Delete to remove the instrument-name–source relation)

@PouyaMohseni PouyaMohseni marked this pull request as ready for review December 10, 2025 19:47
@yinanazhou
Copy link
Member

Please use rebase instead of merge if possible

- display aliases using nested rows
- show verification status and action options for aliases
- remove source information as part of improvements related to #443

resolves #423, resolves #420
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Aliases also need un/verified tags Seperation of Alias

3 participants