fix: do not show facet counts if it is zero #431
+6
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- put `all_facets[value]["count"] = 0` to when there is no contextual facet data to show zero when query does not match - in `index.html` show count if it is more than zero resolved #414
PouyaMohseni
force-pushed
the
zero-facet
branch
from
fa06642 to
ade52ff
Compare
Member
|
Can’t you just set facet.mincount=1 in your Solr request? Or am I missing something? |
Contributor
Author
|
I believe we need the other facets to be shown, especially now that we decided not to use |
PouyaMohseni
changed the title
PouyaMohseni
requested review from
yinanazhou
and removed request for
yinanazhou
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
all_facets[value]["count"] = 0to when there is no contextual facet data to show zero when query does not matchindex.htmlshow count if it is more than zeroresolved #414