feat: fetch and display all Wikidata images for instruments #465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PouyaMohseni
force-pushed
the
image-wikidata
branch
from
12cea45 to
9cf6e25
Compare
- In `import_instruments.py`, query Wikidata via SPARQL to retrieve all image statements
for each instrument in `umil_instruments`
- Record results in `wikidata_images.csv` as `instrument,image`, allowing multiple
rows per instrument
- Continue recording the primary Wikidata image as both the thumbnail and original image
- Preserve the existing image indexing scheme; newly added images are suffixed with `_{i}`,
starting from 1
- Download additional images using the existing logic in `import_instrument.py`
- rank results based on `wikibase:PreferredRank`, having the Wikidata prefered image in the thumbnail
PouyaMohseni
force-pushed
the
image-wikidata
branch
from
9cf6e25 to
bc2dc48
Compare
PouyaMohseni
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wikidata_images.csv._isuffix..svgimages viacairosvg.resolves #464, ref: #424