Merge develop into main #505
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set the active tab to "instruments" for instrument detail page - Removed active style to unify active navtab style refs: #391
- Removed existing google translate widge on initialization - Added event listeners for navigation refs: #394
fix: instrument navbar style
fix: add navigation support for google translate
- Google translate doesn't work well with numbers. The best practice is to only put human-readable part in a separate span. - This is needed to make sure that all the hbs items can be translated well. refs: #393
fix: move count num outside of hbs facet list for google translate
fix: change detail page title to instrument name
…n UMIL_db" This reverts commit 82900f6.
- Added test for `cookies.ts`, `NameValidator.ts`, and `WikidataService.ts`. - Added Makefile for running frontend tests using Docker. - Added CI test for frontend unit test refs: #398
- Updated all related functions
- Removed id selector for language btns on home page as in there are two of each, one for desktop and one for mobile - Added `.desktop` and `.mobile` to distinguish the layout - Updated event listeners for this change
fix: handle multiple Go To Page inputs
fix: avoid errors by using edismax for Solr contextual queries
fix: limit table height only if more than 5 labels
Improve RTL/LTR support and prevent unwanted translations in UI
fix: add http error handling
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 5 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
web-app/django/VIM/apps/instruments/management/commands/import_languages.py
Show resolved
Hide resolved
- Add CreateInstrument Django view with form handling and validation - Implement frontend UI with CreateInstrument TypeScript module - Add CreateInstrumentValidator for frontend form validation - Add CreateInstrumentManager for API interactions and DatabaseService - Create error_codes and exceptions modules for structured error handling - Add migration 0012 for instrument creation feature - Update InstrumentName and AVResource models to support creation workflow - Update management commands (import, download, index) for creation compatibility - Update instrument views and templates with creation UI - Update Docker Compose and nginx configurations - Add comprehensive test suite for creation workflows ref: #406
- Add Django DELETE endpoint with permission checks for user-created instruments - Add confirmation modal template and delete button on detail page - Add TypeScript DeleteInstrumentManager for modal interaction and API call - Add Solr cleanup on successful deletion via transaction.on_commit - Restrict delete access to instrument creator and superusers
- Create NameRowManager class to extract duplicated name row management logic (row creation, RTL support, add/remove rows, form data collection) - Refactor AddNameManager to use NameRowManager via composition - Refactor CreateInstrumentManager to use NameRowManager via composition - Move AddName publish logic from entry point into AddNameManager for consistency - Fix DeleteNameManager to use shared getCsrfToken utility instead of private method - Update entry points (AddName.ts, CreateInstrument.ts) to follow consistent initialization pattern
Feature: create/delete instruments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the latest changes from
developintomain. This should trigger the latest release-deployment workflow described in https://github.com/DDMAL/UMIL/wiki/Deployment-%26-ReleaseNote
Bold highlights denote major areas.
mainand production deploy workflow with version selection, validation, rollback to last deployed, and docker build/up; fix CI build formattingdocker-compose-test.yml, test dataset, and.envtest DB varsLanguage.html_directionwith migration; enrich language import (headers, SPARQL for text direction); instrument import uses small dataset in test modeedismax; avoid title-casing names; dedupe name additionsWritten by Cursor Bugbot for commit a5ff62c. This will update automatically on new commits. Configure here.