Skip to content

feat: add normalized version of language autonyms for input matching #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PouyaMohseni wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat: add normalized version of language autonyms for input matching #508

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions web-app/frontend/src/instruments/helpers/AddNameManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,12 @@ import { WikidataLanguage, AddNameForm, NameEntry } from '../Types';
import { NameValidator } from './NameValidator';
import { Modal } from 'bootstrap';

function normalize(str: string): string {
return str
.normalize('NFD') // split accents
.replace(/[\u0300-\u036f]/g, ''); // remove accents
}

export class AddNameManager {
private rowIndex: number = 1;
private languages: WikidataLanguage[];
Expand All @@ -20,12 +26,22 @@ export class AddNameManager {
row.classList.add('row', 'mb-1', 'name-row');

// Create datalist options dynamically using the languages
let datalistOptions: string = this.languages
.map(
(language: WikidataLanguage) => `
<option value="${language.wikidata_code}">${language.autonym} - ${language.en_label}</option>
`,
)
let datalistOptions = this.languages
.map((language) => {
const normalizedAutonym = normalize(language.autonym);
// Only include normalized version if it's different
const displayNormalized =
normalizedAutonym !== language.autonym
? ` (${normalizedAutonym})`
: '';

return `
<option
value="${language.wikidata_code}"
label="${language.autonym}${displayNormalized} – ${language.en_label}">
</option>
`;
})
.join('');

row.innerHTML = `
Expand Down