-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write liquescent via nc@curve #127
Conversation
This should fix the scipy security warning by updating the dependencies for the "fonts" scripts.
Fixed: Dependabot warning on scipy
Integrate lates changes from DDMAL
Merge upstream changes
Updated changes:
|
src/view_neume.cpp
Outdated
@@ -274,7 +274,9 @@ void View::DrawNc(DeviceContext *dc, LayerElement *element, Layer *layer, Staff | |||
} | |||
|
|||
// Draw the children | |||
this->DrawLayerChildren(dc, nc, layer, staff, measure); | |||
if (!nc->FindDescendantByType(LIQUESCENT)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally we always render child elements individually. So if the encoding is:
<nc>
<liquescent/>
</nc>
We expect the liquescent to be drawn in a call to DrawLayerChildren
so the SVG will be
<g class="nc">
<g class="liquescent"/>
</g>
This is important if you have editorial markup:
<nc>
<add>
<liquescent/>
</add>
</nc>
Which then becomes:
<g class="nc">
<g class="add">
<g class="liquescent"/>
<g/>
</g>
Which allows (for example) to highlight what has been added. This would be missing with your implementation because <liquescent>
drawing is happening in nc
drawing.
I've added
|
Neon issue DDMAL/Neon#1169