Add current_namespace to ID callback controller #411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The qualifications ID callback controller doesn't inherit from QualificationsInterfaceController so the analytics namespace isn't being set. The omniauth_callbacks_controller doesn't require any of the other methods from that base controller so just add the namespace explicitly.
gpeng
force-pushed
the
add-namespace-for-auth-failures
branch
from
8c49eb1 to
7faf16f
Compare
felixclack
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We add a namespace to the DfE Analytics web request payload to allow us to differentiate between Check and AYTQ requests. That is done in the service specific base controllers but the omniauth callback controller for AYTQ doesn't use that and so wasn't setting the namespace and consequently requests to
/qualifications/users/auth/identity/callbackaren't namespaced in BigQuery.Changes proposed in this pull request
Set the namespace explicitly in the controller.