Change how we display Mandatory Qualifications in Check #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add support for rendering multiple MQs by following the same approach we use for NPQs - Change the MQ section heading and make the row key more specific to accommodate for the fact that we may be rendering multiple MQs for different specialisms - Update test data and system spec to cover these changes
malcolmbaig
requested review from
a team,
steventux,
felixclack and
gpeng
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We need to support rendering of multiple MQs, and the headings need some adjustment.
Changes proposed in this pull request
Guidance to review
For simplicity I've put MQs just above NPQs, and below all other quals. Does ordering matter? An alternative ordering is possible but at the expense of code complexity.
Link to Trello card
https://trello.com/c/oz1IKYZ6/144-update-mq-and-npq-rendering
Checklist