Skip to content

[AQTS-760] Passport changes for assessment pages (Personal information section) #2606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Hassanmir92
Copy link
Collaborator

@Hassanmir92 Hassanmir92 commented Jan 20, 2025

Ticket: https://dfedigital.atlassian.net/browse/AQTS-760

Changes: Assessment factory updates based on whether the application provided passport as proof of identity.

This change ensures that if an application has passport uploaded as a way to verify identity, the assessment sections and checks in place clearly show that.

As well as content changes across assessment, FI and declines, we also introduce a new decline reason if the passport has been expired.

Example:
Screenshot 2025-01-20 at 17 35 32

For existing applications that uploaded ID, the page will look as it did before:
Screenshot 2025-01-20 at 17 35 42

Copy link

@Hassanmir92 Hassanmir92 changed the title [AQTS-761] Passport changes for assessment pages (Personal information section) [AQTS-760] Passport changes for assessment pages (Personal information section) Jan 30, 2025
@Hassanmir92 Hassanmir92 force-pushed the AQTS-761-dev-passport-changes-for-cms-check-personal-information-passport-only branch from e7ef45d to 87c504b Compare January 31, 2025 10:07
@@ -167,6 +170,9 @@ en:
identification_document_mismatch: The name on the online application form is different from the ID document, but no evidence of change of name was provided.
name_change_document_illegible: The evidence of change of name is illegible or in a format that we cannot accept.
not_qualified_to_teach_mainstream: Applicant is not qualified to teach in mainstream education.
passport_document_expired: The passport had already expired when the application was submitted.
passport_document_illegible: There is a problem with the passport. For example, it's incorrect, illegible, or incomplete.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this apostrophe need to change

passport_document_illegible: Your passport is illegible or in a format we cannot accept.
passport_document_mismatch: Your name on the online application form is different from the passport, but no evidence of change of name has been provided.
passport_document_expired: Your passport had already expired when the application was submitted.
passport_document_illegible: There is a problem with your passport. For example, it's incorrect, illegible, or incomplete.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this apostrophe need to change

Copy link
Contributor

@syed87 syed87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Hassanmir92 Hassanmir92 force-pushed the AQTS-761-dev-passport-changes-for-cms-check-personal-information-passport-only branch from c06da7f to e1ec8b3 Compare February 5, 2025 12:14
@Hassanmir92 Hassanmir92 merged commit 6ad80c5 into main Feb 5, 2025
16 checks passed
@Hassanmir92 Hassanmir92 deleted the AQTS-761-dev-passport-changes-for-cms-check-personal-information-passport-only branch February 5, 2025 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants