Merge pull request #10299 from DFE-Digital/cv/one-login-redirect-to-e…

…rror-page

Redirect the candidate to the correct error page

app/controllers/one_login_controller.rb

@@ -24,6 +24,7 @@ def callback
     )
 
     if e.is_a?(OneLoginUser::Error)
+      session_error.wrong_email_address!
       session[:session_error_id] = session_error.id
       Sentry.capture_message(
         "One login session error, check session_error record #{session_error.id}",
@@ -73,8 +74,16 @@ def sign_out
 
   def sign_out_complete
     if session[:session_error_id].present?
+      session_error = SessionError.find_by(id: session[:session_error_id])
       reset_session
-      redirect_to candidate_interface_wrong_email_address_path
+
+      path_to_error_page = if session_error&.wrong_email_address?
+                             candidate_interface_wrong_email_address_path
+                           else
+                             internal_server_error_path
+                           end
+
+      redirect_to path_to_error_page
     else
       redirect_to candidate_interface_create_account_or_sign_in_path
     end

app/models/session_error.rb

@@ -1,3 +1,8 @@
 class SessionError < ApplicationRecord
   belongs_to :candidate, optional: true
+
+  enum :error_type, {
+    internal: 'internal',
+    wrong_email_address: 'wrong_email_address',
+  }
 end

spec/requests/one_login_controller_spec.rb

@@ -229,6 +229,11 @@
       )
       expect(session[:session_error_id]).to eq(SessionError.last.id)
       expect(response).to redirect_to(auth_one_login_sign_out_path)
+
+      # a failure will need to call sign_out_complete
+      get auth_one_login_sign_out_complete_path
+
+      expect(response).to redirect_to(internal_server_error_path)
     end
   end
 end