Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PWNN-2097 Ability to select DfE approved or CAB approved framework #1998

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

edwin-jebaraj
Copy link
Collaborator

Changes in this PR

PWNN-2097 Ability to select DfE approved or CAB approved framework

app/controllers/support/frameworks_controller.rb - Added new condtion to filter approved framework

Screen-shots or screen-capture of UI changes

Copy link

Test coverage

Line: 87.06%
Branch: 77.1%

Copy link

Test coverage

Line: 87.26%
Branch: 77.23%

Copy link
Collaborator

@threedaymonk threedaymonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, please rebase and then it can be merged.

@edwin-jebaraj edwin-jebaraj force-pushed the PWNN-2097-select-approved-framework branch from 927435a to 157cf70 Compare November 26, 2024 10:31
Copy link

Test coverage

Line: 87.26%
Branch: 77.23%

@edwin-jebaraj edwin-jebaraj merged commit 1b22e4a into main Nov 26, 2024
24 checks passed
@edwin-jebaraj edwin-jebaraj deleted the PWNN-2097-select-approved-framework branch November 26, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants