Tidy code #2000
Merged
Tidy code #2000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
threedaymonk
commented
Nov 26, 2024
threedaymonk
commented
- Disabled specs are enabled, fixed, or removed as appropriate
- Commented-out code is deleted
- Translations are normalised using i18n-tasks
threedaymonk
requested review from
serenaabbott11 and
edwin-jebaraj
as code owners
Test coverageLine: 87.1% |
|
SonarCloud has some spurious complaints about new code that doesn't exist! |
threedaymonk
force-pushed
the
tidy-unused-specs
branch
2 times, most recently
from
089bf38 to
2bd5e15
Compare
Test coverageLine: 87.27% |
serenaabbott11
approved these changes
Nov 29, 2024
These specs were disabled when phone number validation was removed in commit 3d36c96. They will always be in the version history, so we don't need them preserved here.
This contained only one spec, which was disabled when the validation was removed in commit 6f70ffd.
There never was a spec here. The intention is lost in time, like tears in rain.
This was disabled in commit 7d576e8 with the message "Test by disabling the suspected culprit". Test what, though? And was this the culprit? We can't know.
This spec failed because there was a confusion between keyword arguments and old-style hash arguments. It is fixed by using keyword arguments consistently.
We have version history. We don't need to keep unused code around in comments "just in case".
Done by running: i18n-tasks normalize
This is extremely slow, and wasn't being run. We still have the same functionality with i18n-tasks.
The classes referred to by these specs were deleted in the Great Email Refactor of October 2023, commit 988bc05.
These were disabled a year ago in commit d57130d, which adds other tests for the behaviour of attachments. These specs are no longer needed nor useful.
threedaymonk
force-pushed
the
tidy-unused-specs
branch
from
2bd5e15 to
61f3418
Compare
|
Test coverageLine: 87.03% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.