Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SC-83 Invite evaluators to start evaluation tasks #2017

Merged
merged 2 commits into from
Jan 20, 2025
Merged

SC-83 Invite evaluators to start evaluation tasks #2017

merged 2 commits into from
Jan 20, 2025

Conversation

edwin-jebaraj
Copy link
Collaborator

Changes in this PR

  1. app/controllers/support/cases/email_evaluators_controller.rb - Added new controller
  2. app/models/email/template_parser.rb - Added new parse variable
  3. app/views/support/cases/email_evaluators/_document_list.html.erb - Added new view file to list uploaded documents
  4. app/views/support/cases/email_evaluators/_email_list.html.erb - Added new view file to list evaluators
  5. app/views/support/cases/email_evaluators/_form.html.erb - Added new form file
  6. app/views/support/cases/email_evaluators/_form_template.html.erb - Added new default template file
  7. app/views/support/cases/email_evaluators/edit.html.erb - Added new view file
  8. app/views/support/cases/show/_tasklist.html.erb - Updated email evaluator link in task list
  9. config/locales/en.yml - added new language variable
  10. config/routes.rb - Added new route for email_evaluators
  11. db/migrate/20241211171744_add_sent_email_to_evaluators_to_case.rb - Added new migration file
  12. spec/features/support/agent_can_email_to_evaluators_spec.rb - Added new spec file for testing

Screen-shots or screen-capture of UI changes

@edwin-jebaraj edwin-jebaraj force-pushed the SC-83-invite-evaluators branch 2 times, most recently from 9ef7d50 to 577cd5c Compare December 12, 2024 18:41
@github-actions GitHub Actions

This comment was marked as resolved.

Sign in to view
@github-actions GitHub Actions
Copy link

Test coverage

Line: 87.16%
Branch: 76.97%

@github-actions GitHub Actions
Copy link

Test coverage

Line: 87.15%
Branch: 76.94%

@edwin-jebaraj edwin-jebaraj force-pushed the SC-83-invite-evaluators branch 2 times, most recently from 82416d3 to 9a945fd Compare December 13, 2024 12:32
@github-actions GitHub Actions
Copy link

Test coverage

Line: 87.16%
Branch: 76.99%

@edwin-jebaraj edwin-jebaraj force-pushed the SC-83-invite-evaluators branch from 3917845 to e627c28 Compare January 8, 2025 18:08
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 8, 2025

Test coverage

Line: 87.17%
Branch: 76.97%

threedaymonk
threedaymonk requested changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@threedaymonk threedaymonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also test that the email is sent and that the link in the email goes somewhere useful, so that we have confidence in the whole process from end to end?

app/controllers/support/cases/email_evaluators_controller.rb Outdated Show resolved Hide resolved
app/models/email/template_parser.rb Show resolved Hide resolved
spec/features/support/agent_can_email_to_evaluators_spec.rb Outdated Show resolved Hide resolved
spec/models/support/case_spec.rb Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Test coverage

Line: 86.99%
Branch: 76.83%

1 similar comment
@github-actions GitHub Actions
Copy link

Test coverage

Line: 86.99%
Branch: 76.83%

@edwin-jebaraj edwin-jebaraj force-pushed the SC-83-invite-evaluators branch from cfaea65 to f6148d5 Compare January 15, 2025 18:03
@github-actions GitHub Actions
Copy link

Test coverage

Line: 87.15%
Branch: 76.94%

threedaymonk
threedaymonk reviewed Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@threedaymonk threedaymonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is OK, but I'm going to ask @serenaabbott11 to take a look as she's working more directly on this and might spot something I've missed.

app/views/support/cases/show/_tasklist.html.erb Outdated Show resolved Hide resolved
config/routes.rb Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

Test coverage

Line: 87.16%
Branch: 76.94%

@edwin-jebaraj edwin-jebaraj merged commit 6d857b8 into main Jan 20, 2025
25 checks passed
@edwin-jebaraj edwin-jebaraj deleted the SC-83-invite-evaluators branch January 20, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@threedaymonk threedaymonk threedaymonk approved these changes

@serenaabbott11 serenaabbott11 Awaiting requested review from serenaabbott11 serenaabbott11 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edwin-jebaraj @threedaymonk