Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SC-78 Evaluator journey: accessing evaluation from a link #2022

Merged
merged 2 commits into from
Jan 20, 2025
Merged

SC-78 Evaluator journey: accessing evaluation from a link #2022

merged 2 commits into from
Jan 20, 2025
+27 −0

Conversation

edwin-jebaraj
Copy link
Collaborator

Changes in this PR

  1. app/controllers/cms_entry_points_controller.rb - check email_evaluator_link session and redirect to evaluator tasklist page
  2. app/services/create_user.rb - updated dsi_uid to the support evaluators

Screen-shots or screen-capture of UI changes

threedaymonk
threedaymonk requested changes Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@threedaymonk threedaymonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this behaviour is worth adding, it's worth testing, so that we know what it's meant to do!

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

Test coverage

Line: 87.13%
Branch: 76.89%

@edwin-jebaraj edwin-jebaraj merged commit b5d4542 into main Jan 20, 2025
25 checks passed
@edwin-jebaraj edwin-jebaraj deleted the SC-78-dfe-signin branch January 20, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@threedaymonk threedaymonk threedaymonk approved these changes

@serenaabbott11 serenaabbott11 Awaiting requested review from serenaabbott11 serenaabbott11 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edwin-jebaraj @threedaymonk