SC-86 Evaluator journey: Upload complete evaluation #2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwin-jebaraj
requested review from
serenaabbott11 and
threedaymonk
as code owners
| @@ -8,14 +8,18 @@ class Support::Case::DocumentUploader | |||
| attribute :support_case | |||
| attribute :has_uploaded_documents | |||
|
|
|||
| validates :files, presence: true, if: -> { support_case.has_uploaded_documents.nil? } | |||
| validates :files, presence: true, if: -> { has_uploaded_documents.blank? } | |||
There was a problem hiding this comment.
I'm confused by the semantics here. Why is it important that it's blank? rather than a boolean check?
There was a problem hiding this comment.
We need to validate the upload confirmation "Yes" or "No". By default it is blank which means no radio button selected.
| @@ -0,0 +1,5 @@ | |||
| class AddHasUploadedDocumentsToSupportEvalutors < ActiveRecord::Migration[7.2] | |||
| def change | |||
| add_column :support_evaluators, :has_uploaded_documents, :boolean | |||
There was a problem hiding this comment.
Consider adding a default (probably false) and making this non-NULL.
|
Test coverageLine: 86.95% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR
Added new files to upload completed documents
Screen-shots or screen-capture of UI changes