Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SC-78 fixed parsing issue when sub category is nil #2025

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

edwin-jebaraj
Copy link
Collaborator

Changes in this PR

SC-78 fixed parsing issue when sub category is nil

Screen-shots or screen-capture of UI changes

Copy link
Collaborator

@threedaymonk threedaymonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All bugs fixed should have tests. Ideally, the test should be written first, and fail, and then pass when the code is fixed.

Copy link
Collaborator

@threedaymonk threedaymonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this solves the immediate problem (error instead of page loading) but instead of "[sub_category]", maybe we shouldn't be interpolating the category at all if it's missing.

Copy link

Test coverage

Line: 87%
Branch: 77.09%

@edwin-jebaraj edwin-jebaraj merged commit 99a8bc9 into main Jan 23, 2025
25 checks passed
@edwin-jebaraj edwin-jebaraj deleted the SC-78-issue-fix branch January 23, 2025 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants