Skip to content

ES-424 amend survey link and guidance #2183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 4, 2025
Merged

ES-424 amend survey link and guidance #2183

merged 3 commits into from
Jun 4, 2025

Conversation

serenaabbott11
Copy link
Contributor

@serenaabbott11 serenaabbott11 commented Jun 3, 2025 •
edited
Loading

Changes in this PR

  • Change some of the wording in the onboarding pages and add a line above the related actions to match the prototype
  • Change the service to be energy for schools for the customer satisfaction survey when coming from an energy url
  • Add confirmation screen as a source so that the end of journey survey works

Screen-shots or screen-capture of UI changes

@serenaabbott11 serenaabbott11 self-assigned this Jun 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2025

Test coverage

Line: 87.26%
Branch: 75.5%

@serenaabbott11 serenaabbott11 marked this pull request as ready for review June 3, 2025 10:45
dinesh16
dinesh16 approved these changes Jun 3, 2025
View reviewed changes
Copy link
Collaborator

@dinesh16 dinesh16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2025

Test coverage

Line: 87.12%
Branch: 75.41%

@serenaabbott11 serenaabbott11 force-pushed the es-424-amend-survey-link-and-guidance branch from 29a493e to 5627355 Compare June 4, 2025 09:34
@serenaabbott11 serenaabbott11 force-pushed the es-424-amend-survey-link-and-guidance branch from 5627355 to b94a6f8 Compare June 4, 2025 12:52
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 4, 2025

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@serenaabbott11 serenaabbott11 merged commit 63aa026 into main Jun 4, 2025
25 checks passed
@serenaabbott11 serenaabbott11 deleted the es-424-amend-survey-link-and-guidance branch June 4, 2025 13:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 4, 2025

Test coverage

Line: 87.48%
Branch: 77.18%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dinesh16 dinesh16 dinesh16 approved these changes

@threedaymonk threedaymonk Awaiting requested review from threedaymonk threedaymonk is a code owner

@edwin-jebaraj edwin-jebaraj Awaiting requested review from edwin-jebaraj edwin-jebaraj is a code owner

@doctorpod doctorpod Awaiting requested review from doctorpod doctorpod is a code owner

Assignees

@serenaabbott11 serenaabbott11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serenaabbott11 @dinesh16