Skip to content

Commit

Permalink
Merge pull request #241 from DFE-Digital/revert-231-temp-disable-send…
Browse files Browse the repository at this point in the history
…ing-data-to-crm

Revert "Temporarily disable sending data to the CRM"
  • Loading branch information
ethax-ross authored Sep 7, 2020
2 parents e28213e + 095d899 commit 0012096
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions GetIntoTeachingApi/Jobs/UpsertCandidateJob.cs
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,7 @@ public void Run(Candidate candidate, PerformContext context)

private void SaveCandidate(Candidate candidate)
{
// TODO: temporarily disabled to avoid collecting PII in a UR session.
// _crm.Save(candidate);
_crm.Save(candidate);
}

private IEnumerable<TeachingEventRegistration> ClearTeachingEventRegistrations(Candidate candidate)
Expand Down
3 changes: 1 addition & 2 deletions GetIntoTeachingApiTests/Jobs/UpsertCandidateJobTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ public UpsertCandidateJobTests()
_mockContext.Object, _mockLogger.Object);
}

/* TODO: temporarily disabled to avoid collecting PII in a UR session.
[Fact]
public void Run_OnSuccess_SavesCandidate()
{
Expand All @@ -59,7 +58,7 @@ public void Run_WithTeachingEventRegistrationsOnSuccess_SavesTeachingEventRegist

_mockCrm.Verify(mock => mock.Save(registration), Times.Once);
registration.CandidateId.Should().Be(candidateId);
}*/
}

[Fact]
public void Run_OnFailure_EmailsCandidate()
Expand Down

0 comments on commit 0012096

Please sign in to comment.