Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data migrate to version 11.0.0.rc3 #4490

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

avinhurry
Copy link
Collaborator

@avinhurry avinhurry commented Sep 4, 2024

Context

Upgrade the data migrate gem to 11 rc3 which is pretty much ready to be 11.0

We are getting errors:

https://dfe-teacher-services.sentry.io/issues/5787827580/?alert_rule_id=11137790&alert_type=issue&notification_uuid=8bebb020-94ef-47d9-9df3-c8628f5aabf8&project=1377944&referrer=slack

Guidance to review

image

Things to check

  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
  • API release notes have been updated if necessary
  • Required environment variables have been updated added to the Azure KeyVault
  • Inform data insights team due to database changes
  • Make sure all information from the Trello card is in here
  • Rebased main
  • Cleaned commit history
  • Tested by running locally
  • Attach PR to Trello card

@avinhurry avinhurry marked this pull request as ready for review September 4, 2024 09:29
@avinhurry avinhurry closed this Sep 4, 2024
@avinhurry avinhurry reopened this Sep 4, 2024
@avinhurry avinhurry requested a review from a team September 4, 2024 10:01
@avinhurry avinhurry merged commit 91e47fe into main Sep 4, 2024
57 of 58 checks passed
@avinhurry avinhurry deleted the update-data-migrate branch September 4, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants