So/cognitive search service adapter #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng scaffolding at the application and domain levels.
CathLass
reviewed
Jul 10, 2024
| using Dfe.Data.SearchPrototype.Search.Domain.AggregateRoot; | ||
|
|
||
| namespace Dfe.Data.SearchPrototype.Search.Application.Adapters | ||
| { |
There was a problem hiding this comment.
When you're talking about adaptors, that's in the context of ports and adaptors? So this is the port? I think it's worth discussing with Scott whether this code is meant as part-tutorial and if it is, these comments need to be really well thought-through (and maybe the word 'port' used, if that is the language that we're using)
…com/DFE-Digital/search-prototype into SO/cognitive-search-service-adapter
CathLass
reviewed
Jul 10, 2024
| /// <exception cref="JsonSerializationException"> | ||
| /// Exception thrown if there is a problem deserialising the derived string document object. | ||
| /// </exception> | ||
| public static ExpandoObject? DeserialiseSearchResultDocument(this SearchResult<object> searchResult) |
There was a problem hiding this comment.
I didn't expect to still be using ExpandoObjects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.