Cl/handle search infrastructure exceptions #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CathLass
commented
Aug 7, 2024
| Closed = 0, | ||
| Open = 1, | ||
| Unknown | ||
| } |
There was a problem hiding this comment.
This is just a rename from StatusCode - not new code
CathLass
commented
Aug 7, 2024
| InvalidRequest, | ||
| SearchServiceError, | ||
| DataFormatError | ||
| } |
There was a problem hiding this comment.
This is the actual main thing I've added - this response status and the setting of it by the use-case and the mapper
Dfe.Data.SearchPrototype/SearchForEstablishments/SearchResponseStatus.cs
Outdated
Show resolved
Hide resolved
Dfe.Data.SearchPrototype/Infrastructure/Tests/CognitiveSearchServiceAdapterTests.cs
Show resolved
Hide resolved
RogerHowellDfE
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
With the caveat of my comment about the currently unused SearchResponseStatus.DataFormatError (personally I'd not want to block the PR based just on this unused value) and caution re: I don't quite have a full mental model yet of how everything fits together, it's a ✅ from me 👍
- the commits seem to follow a logical progression
- the tests seem to be testing what they say to be testing
- overall this seems a good/reasonable improvement
A few nitpicky comments if we were to refine the PR (i.e., not anything I'd want to block the PR on):
- Seems to be a few nullability mismatches floating around (parameters marked as non-nullable then a robust additional runtime check for null causing warnings, and a few places in the tests use
!to override the nullability declarations) - Possibly split the PR into refactoring changes (renaming/moving) vs functionality (behaviour) changes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added and modified tests to better define and test behaviour
Added a response status to the application layer
Some small tidy-ups like adding a models folder which now makes the PR look massive - sorry about that :(