added facet sorting alphabetically to search adaptor #57
Conversation
| @@ -102,7 +103,7 @@ await _searchByKeywordService.SearchAsync<TSearchResult>( | |||
| { | |||
| Establishments = _searchResultMapper.MapFrom(searchResults.Value.GetResults()), | |||
| Facets = searchResults.Value.Facets != null | |||
| ? _facetsMapper.MapFrom(searchResults.Value.Facets.ToDictionary()) | |||
| ? _facetsMapper.MapFrom(searchResults.Value.Facets.OrderBy(facet => facet.Key).ToDictionary()) | |||
There was a problem hiding this comment.
Is sort order/sequencing definitely a search prototype concern?
My worry is that this is being implemented too "low level" (as opposed to, for example, treating it as a display/web UI concern and doing the sort at the last-reasonable-moment within the view code).
There was a problem hiding this comment.
Roger, I've put the background to this PR in the description, which we should have done in the first place. Maybe it will answer your concern
There was a problem hiding this comment.
Maybe it will answer your concern
I've just had a read and I'm not sure it does.
To illustrate the alternative, what if this sorting was performed in the web mvc project (i.e., the project which displays these values in HTML) as opposed to this shared library project?
This is a bug fix raised by Antony but I can't find the ticket. The issue is that facets don't always display in the same order on the FE - they switch around. In a real project we would expect to have a prescribed order from, say, UCD people, which would be addressed as a presentation concern.