Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2041] Remove provider from aks/dfe_analytics #125

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

saliceti
Copy link
Member

@saliceti saliceti commented Oct 24, 2024

Context

It is not considered good practice to keep the provider definition inside the module

Changes proposed in this pull request

  • Remove the provider definition
  • Refactor and remove unused variables
  • Review IAM roles

Guidance to review

See AFQTS PRs:

Checklist

  • I have performed a self-review of my code, including formatting and typos
  • I have cleaned the commit history
  • I have added the Devops label
  • I have attached the pull request to the trello card

@saliceti saliceti force-pushed the 2041-configure-bigquery-in-the-terraform-module-3 branch from 69184f7 to ea56890 Compare October 24, 2024 15:24
@saliceti
Copy link
Member Author

@saliceti saliceti force-pushed the 2041-configure-bigquery-in-the-terraform-module-3 branch from 519cc14 to 5e047e8 Compare October 24, 2024 16:27
@saliceti saliceti merged commit 0400820 into main Oct 25, 2024
3 checks passed
@saliceti saliceti deleted the 2041-configure-bigquery-in-the-terraform-module-3 branch October 25, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants