Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FlightPlan properties which are actually optional #142

Merged
merged 5 commits into from
Jul 11, 2024

Conversation

kouak
Copy link
Contributor

@kouak kouak commented Jul 11, 2024

Some properties were marked as non-optional, they are now correctly marked as optional.

Fix some typos.

Copy link

changeset-bot bot commented Jul 11, 2024

🦋 Changeset detected

Latest commit: 87f74ab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@dgac/nmb2b-client Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kouak kouak merged commit 88d709b into master Jul 11, 2024
4 checks passed
Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.97%. Comparing base (7052d08) to head (87f74ab).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #142   +/-   ##
=======================================
  Coverage   94.97%   94.97%           
=======================================
  Files          51       51           
  Lines        5131     5132    +1     
  Branches      259      259           
=======================================
+ Hits         4873     4874    +1     
  Misses        256      256           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kouak kouak deleted the fix-optional-properties-in-FlightPlan branch July 11, 2024 15:38
@github-actions github-actions bot mentioned this pull request Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant