Open
Conversation
yangjiae12
reviewed
Dec 2, 2025
Member
yangjiae12
left a comment
yangjiae12
left a comment
There was a problem hiding this comment.
대부분 코드 깔끔하게 잘 작성하신 것 같습니다! 수고하셨습니다
| import retrofit2.Retrofit | ||
| import retrofit2.converter.gson.GsonConverterFactory | ||
|
|
||
| const val BASE_URL = "http://43.200.73.115:8080/" |
Member
There was a problem hiding this comment.
작성하신 BASE_URL을 보니 IP 주소를 상수에 그대로 적으셨는데, 프로젝트를 할 때는 보통 저렇게 하지 않습니다. Git 같은 곳에 올릴 때 서버가 노출되면 보안상 좋지 않기 때문에 보통은 local.properties라는 파일에 숨겨두고, build.gradle을 통해 불러오는 방식을 씁니다! 나중에 한번 찾아보시면 좋을 것 같아요~
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 PR 제목
✅ 변경 사항
📷 영상 및 스크린샷
Screen_Recording_20251127-004118_week2.mp4
🔗 알게 된 사항
API 연동, 서버와 클라이언트 간 데이터 전달 방법 등등등
📝 질문 사항