feat: better filter ux #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it easier to see whether a filter is applied or not and how to apply it.
i.e. when opening or closing a group + some optimization to some useEffect dependencies
Loxeris
force-pushed
the
feat_better_filter_ux
branch
from
b18906c
to
4bd94e1
Compare
aldbr
reviewed
Aug 27, 2024
There was a problem hiding this comment.
It looks good, I just have minor comments:
- how hard would it be to unit test the new logic? (checking that the info appears, checking the presence and the colors of the chips?)
- when I (i) create filters, (ii) apply them, (iii) remove one of them, I have the message but the remaining chips stay green. Is it expected? It is fine to me, as there is the info, but I am just wondering how "complex" it would be to paint them back in grey? (without involving too much code just for that)
Loxeris
force-pushed
the
feat_better_filter_ux
branch
from
8653b7b
to
48818ff
Compare
It is expected, as it seemed more intuitive to me to keep them green since they still have an effect on the table data. Painting them back to grey would need a bit of work but could probably be done pretty quickly |
I think you are right. Let's keep it like this. |
aldbr
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it easier to see whether a filter is applied or not.
Filters are now green when they are applied and grey when they are not.
Moreover, an info box warns you when some filter changes are not applied.