Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update() to NanoImage #493

Closed
wants to merge 1 commit into from
Closed

Conversation

Simon-L
Copy link
Contributor

@Simon-L Simon-L commented Mar 17, 2025

Following suggestions on adding this, I added an update() method to the NanoImage class.

Inspired from: memononen/nanovg#269 (comment)
Possible example usage in the Meters UI example: https://gist.github.com/Simon-L/65ac25c8caddebf11190c70b9dfea8a7#file-exampleuimeters-cpp-L226-L252

@Simon-L
Copy link
Contributor Author

Simon-L commented Mar 20, 2025

This PR causes an issue somewhere that breaks the texture update in certain circumstances. One case found for now is when adding the NanoButton class found in the FileHandling example
Here's a minimal example reproducing the issue: https://github.com/Simon-L/DPF-minimal-nanoimage-update

@falkTX
Copy link
Contributor

falkTX commented Mar 20, 2025

Added in 5d3e0ad in a more safe way

@falkTX falkTX closed this Mar 20, 2025
@Simon-L
Copy link
Contributor Author

Simon-L commented Mar 20, 2025

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants