fix(daily dev): fixed routes and added one new one (#18021)

* add squads

* style: auto format

* null check

* fix: add null checks for items

* changes

* trigger

* use params

* fix: add categories

---------

Co-authored-by: rjnishant530 <singhnisant530@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

lib/routes/alistapart/index.ts

@@ -3,16 +3,18 @@ import { getData, getList } from './utils';
 
 export const route: Route = {
     path: '/',
+    categories: ['programming'],
     radar: [
         {
             source: ['alistapart.com/articles/'],
-            target: '',
+            target: '/',
         },
     ],
-    name: 'Unknown',
+    name: 'Home Feed',
     maintainers: ['Rjnishant530'],
     handler,
     url: 'alistapart.com/articles/',
+    example: '/alistapart',
 };
 
 async function handler() {

lib/routes/alistapart/topic.ts

@@ -17,6 +17,7 @@ export const route: Route = {
     radar: [
         {
             source: ['alistapart.com/blog/topic/:topic'],
+            target: '/:topic',
         },
     ],
     name: 'Topics',

lib/routes/daily/discussed.ts

@@ -1,5 +1,5 @@
-import { Route } from '@/types';
-import { baseUrl, getData, getList } from './utils.js';
+import { Route, ViewType } from '@/types';
+import { baseUrl, getData, getList, variables } from './utils.js';
 
 const query = `
   query MostDiscussedFeed(
@@ -52,8 +52,9 @@ const query = `
 `;
 
 export const route: Route = {
-    path: '/discussed',
-    example: '/daily/discussed',
+    path: '/discussed/:period?/:innerSharedContent?/:dateSort?',
+    example: '/daily/discussed/30',
+    view: ViewType.Articles,
     radar: [
         {
             source: ['app.daily.dev/discussed'],
@@ -63,19 +64,52 @@ export const route: Route = {
     maintainers: ['Rjnishant530'],
     handler,
     url: 'app.daily.dev/discussed',
+    parameters: {
+        innerSharedContent: {
+            description: 'Where to Fetch inner Shared Posts instead of original',
+            default: 'false',
+            options: [
+                { value: 'false', label: 'False' },
+                { value: 'true', label: 'True' },
+            ],
+        },
+        dateSort: {
+            description: 'Sort posts by publication date instead of popularity',
+            default: 'true',
+            options: [
+                { value: 'false', label: 'False' },
+                { value: 'true', label: 'True' },
+            ],
+        },
+        period: {
+            description: 'Period of Lookup',
+            default: '7',
+            options: [
+                { value: '7', label: 'Last Week' },
+                { value: '30', label: 'Last Month' },
+                { value: '365', label: 'Last Year' },
+            ],
+        },
+    },
 };
 
 async function handler(ctx) {
     const limit = ctx.req.query('limit') ? Number.parseInt(ctx.req.query('limit'), 10) : 20;
-    const link = `${baseUrl}/discussed`;
+    const innerSharedContent = ctx.req.param('innerSharedContent') ? JSON.parse(ctx.req.param('innerSharedContent')) : false;
+    const dateSort = ctx.req.param('dateSort') ? JSON.parse(ctx.req.param('dateSort')) : true;
+    const period = ctx.req.param('period') ? Number.parseInt(ctx.req.param('period'), 10) : 7;
+
+    const link = `${baseUrl}/posts/discussed`;
 
     const data = await getData({
         query,
         variables: {
+            ...variables,
             first: limit,
+            period,
         },
     });
-    const items = getList(data);
+    const items = getList(data, innerSharedContent, dateSort);
 
     return {
         title: 'Real-time discussions in the developer community | daily.dev',

lib/routes/daily/popular.ts

@@ -0,0 +1,182 @@
+import { Route, ViewType } from '@/types';
+import { baseUrl, getData, getList, variables } from './utils.js';
+
+const query = `
+  query AnonymousFeed(
+    $loggedIn: Boolean! = false
+    $first: Int
+    $after: String
+    $ranking: Ranking
+    $version: Int
+    $supportedTypes: [String!] = ["article","share","freeform","video:youtube","collection"]
+  ) {
+    page: anonymousFeed(
+      first: $first
+      after: $after
+      ranking: $ranking
+      version: $version
+      supportedTypes: $supportedTypes
+    ) {
+      ...FeedPostConnection
+    }
+  }
+  
+  fragment FeedPostConnection on PostConnection {
+    pageInfo {
+      hasNextPage
+      endCursor
+    }
+    edges {
+      node {
+        ...FeedPost
+        contentHtml
+        ...UserPost @include(if: $loggedIn)
+      }
+    }
+  }
+  
+  fragment FeedPost on Post {
+    ...FeedPostInfo
+    sharedPost {
+      id
+      title
+      image
+      readTime
+      permalink
+      commentsPermalink
+      createdAt
+      type
+      tags
+      source {
+        id
+        handle
+        permalink
+        image
+      }
+      slug
+      clickbaitTitleDetected
+    }
+    trending
+    feedMeta
+    collectionSources {
+      handle
+      image
+    }
+    numCollectionSources
+    updatedAt
+    slug
+  }
+  
+  
+  fragment FeedPostInfo on Post {
+    id
+    title
+    image
+    readTime
+    permalink
+    commentsPermalink
+    createdAt
+    commented
+    bookmarked
+    views
+    numUpvotes
+    numComments
+    summary
+    bookmark {
+      remindAt
+    }
+    author {
+      id
+      name
+      image
+      username
+      permalink
+    }
+    type
+    tags
+    source {
+      id
+      handle
+      name
+      permalink
+      image
+      type
+    }
+    userState {
+      vote
+      flags {
+        feedbackDismiss
+      }
+    }
+    slug
+    clickbaitTitleDetected
+  }
+  
+  fragment UserPost on Post {
+    read
+    upvoted
+    commented
+    bookmarked
+    downvoted
+  }
+`;
+
+export const route: Route = {
+    path: '/popular/:innerSharedContent?/:dateSort?',
+    example: '/daily/popular',
+    view: ViewType.Articles,
+    radar: [
+        {
+            source: ['app.daily.dev/popular'],
+        },
+    ],
+    parameters: {
+        innerSharedContent: {
+            description: 'Where to Fetch inner Shared Posts instead of original',
+            default: 'false',
+            options: [
+                { value: 'false', label: 'False' },
+                { value: 'true', label: 'True' },
+            ],
+        },
+        dateSort: {
+            description: 'Sort posts by publication date instead of popularity',
+            default: 'true',
+            options: [
+                { value: 'false', label: 'False' },
+                { value: 'true', label: 'True' },
+            ],
+        },
+    },
+    name: 'Popular',
+    maintainers: ['Rjnishant530'],
+    handler,
+    url: 'app.daily.dev/popular',
+};
+
+async function handler(ctx) {
+    const link = `${baseUrl}/posts`;
+    const limit = ctx.req.query('limit') ? Number.parseInt(ctx.req.query('limit'), 10) : 15;
+    const innerSharedContent = ctx.req.param('innerSharedContent') ? JSON.parse(ctx.req.param('innerSharedContent')) : false;
+    const dateSort = ctx.req.param('dateSort') ? JSON.parse(ctx.req.param('dateSort')) : true;
+
+    const data = await getData({
+        query,
+        variables: {
+            ...variables,
+            ranking: 'POPULARITY',
+            first: limit,
+        },
+    });
+    const items = getList(data, innerSharedContent, dateSort);
+
+    return {
+        title: 'Popular posts on daily.dev',
+        link,
+        item: items,
+        description: 'daily.dev is the easiest way to stay updated on the latest programming news. Get the best content from the top tech publications on any topic you want.',
+        logo: `${baseUrl}/favicon-32x32.png`,
+        icon: `${baseUrl}/favicon-32x32.png`,
+        language: 'en-us',
+    };
+}