-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add padding option to element reference coords #1221
Open
sandro-elsweijer
wants to merge
17
commits into
main
Choose a base branch
from
enhancement-ref_coords
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+359
−214
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
eab99bc
rename t8_forest_element_from_ref_coords
sandro-elsweijer 558e4d7
rename t8_forest_element_coordinate
sandro-elsweijer f54bd58
adapt element ref coords interface and add padding option
sandro-elsweijer 0f5cac9
add ref coord padding for hex
sandro-elsweijer 5e04f66
add ref coord padding for line
sandro-elsweijer 32816ae
add ref coord padding for triangle
sandro-elsweijer 4dc657c
add ref coord padding for tet
sandro-elsweijer d02ec7c
add ref coord padding for prism
sandro-elsweijer 490b73a
add ref coord padding for pyra
sandro-elsweijer cbf308f
add ref coord padding for quad
sandro-elsweijer 35eb338
add ref coord padding for vertex
sandro-elsweijer d7ccb21
adapt ref coords test for padding
sandro-elsweijer 68ae09b
Merge remote-tracking branch 'origin/main' into enhancement-ref_coords
sandro-elsweijer d975a3a
indent
sandro-elsweijer acaa546
indent
sandro-elsweijer e052e29
Apply suggestions from code review
sandro-elsweijer 84a3edd
Merge branch 'main' into enhancement-ref_coords
sandro-elsweijer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -578,12 +578,17 @@ struct t8_eclass_scheme | |||||
* \param [in] coords_input The coordinates \f$ [0,1]^\mathrm{dim} \f$ of the point | ||||||
* in the reference space of the element. | ||||||
* \param [in] num_coords Number of \f$ dim\f$-sized coordinates to evaluate. | ||||||
* \param [in] padding Only used if \a num_coords > 1. | ||||||
* The number of padding entries in \a ref_coords between array elements: | ||||||
* For elem dim 2 and input {x1, y1, x2, y2, ...} padding is 0. | ||||||
* For elem dim 2 and input {x1, y1, z1, x2, y2, z2, ...} padding is 1. | ||||||
* For elem dim 3 and input {x1, y1, z1, x2, y2, z2, ...} padding is 0. | ||||||
* \param [out] out_coords The coordinates of the points in the | ||||||
* reference space of the tree. | ||||||
*/ | ||||||
virtual void | ||||||
t8_element_reference_coords (const t8_element_t *elem, const double *ref_coords, const size_t num_coords, | ||||||
double *out_coords) const | ||||||
const size_t padding, double *out_coords) const | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
= 0; | ||||||
|
||||||
/** Count how many leaf descendants of a given uniform level an element would produce. | ||||||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.