Draft: Implement make_compound function

[AntonReiswich]

In GitLab by @AntonReiswich on Feb 21, 2025, 14:57

Currently, the function make_compound is implemented as in the branch add-geometry-functionality-in-particular-for-use-cases.
It takes an std::vector of TopoDS_Shapes as an argument and returns a TopoDS_Shape.

Let us discuss the API:

• Do we want to keep it that way?
• Do we want the argument to be of type std::vector<Shape> and the return type to be Shape?
• Do we want the argument to be of type Shape, as it is a container type, holding Shapes itself?
• Do we want to overload the function?

[AntonReiswich]

In GitLab by @AntonReiswich on Feb 21, 2025, 14:57

requested review from @klei_j0

[AntonReiswich]

In GitLab by @klei_j0 on Feb 21, 2025, 17:30

Do we want to keep it that way?

In my opinion, no.

Do we want the argument to be of type std::vector<Shape> and the return type to be Shape?

In my opinion, yes. We should take care that history tracking is preservered.

Do we want the argument to be of type Shape, as it is a container type, holding Shapes itself?

I think this would not make much sense, because Shape as a container type is ususally just a wrapper around a TopoDS_Compound and this would defeat the purpose of the function.

[AntonReiswich]

In GitLab by @AntonReiswich on Mar 6, 2025, 14:57

marked this merge request as draft