Shortcode Features - Add Shortcode Column and Copy To Clipboard feature #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronalfy
requested changes
Feb 17, 2024
src/js/utils/index.js
Outdated
|
|
||
| // Copy the value to the clipboard. | ||
| navigator.clipboard.writeText( shortcodeValue ).then( () => { | ||
| // Logs success message in console. |
There was a problem hiding this comment.
There needs to be a check to make sure this object is available in browsers such as Firefox.
See feature detection in this article: https://web.dev/articles/async-clipboard#feature_detection
src/js/utils/index.js
Outdated
| const spanElement = button.querySelector( 'span' ); | ||
| if ( spanElement ) { | ||
| spanElement.classList.remove( 'dashicons', 'dashicons-clipboard' ); | ||
| } |
There was a problem hiding this comment.
Can we change this to a checkbox when copied and use wp.a11y.speak to communicate the button state?
https://make.wordpress.org/accessibility/handbook/markup/wp-a11y-speak/
| // Generate the shortcode for the button with dashicon. | ||
| $button_shortcode = sprintf( | ||
| '<button type="button" class="pw-copy-clipboard" title="Copy to Clipboard">%s</button>', | ||
| '<span class="dashicons dashicons-clipboard"></span>' |
|
|
||
| // Generate the shortcode for the readonly input. | ||
| $shortcode = sprintf( | ||
| '<input type="text" value="%s" readonly>', |
There was a problem hiding this comment.
Can you make sure this input is disabled?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #26
This pull request consists of the following features below: