Enable dynamically linking libmemcpy
#13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When attempting to compile `libmemcpy` to a shared object, linking would fail with complaints about symbol relocations. The root cause of this issue was that the non-function symbols in `cpu.c` used by the various `memcpy*.S` implementations were not marked as hidden like they are [in the corresponding `glibc` source](https://github.com/bminor/glibc/blob/1ea051145612f199d8716ecdf78b084b00b5a727/sysdeps/x86/cacheinfo.h#L31-L36).
Svetlitski
force-pushed
the
cpu-mark-symbols-as-hidden
branch
from
e5016bb to
f00ad93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When attempting to compile
libmemcpyto a shared object, linking would fail with complaints about symbol relocations. The root cause of this issue was that the non-function symbols incpu.cused by the variousmemcpy*.Simplementations were not marked as hidden like they are in the correspondingglibcsource.