Ensure that cached.csr always exists at the beginning #2636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @steven-bellock . Could you review this PR? Thanks. |
steven-bellock
requested changes
Mar 27, 2024
| char *file_name = "test_csr/cached.staging"; | ||
|
|
||
| rename(file_name, new_name); | ||
|
|
There was a problem hiding this comment.
Thanks. I have deleted it.
| @@ -322,6 +332,9 @@ void libspdm_test_requester_get_csr_case1(void **state) | |||
| /*init req_info*/ | |||
| libspdm_gen_req_info(); | |||
|
|
|||
| /*ensure that cached.csr exists in test_csr at the beginning*/ | |||
| libspdm_clear_cached_csr(); | |||
There was a problem hiding this comment.
Probably best to call this from libspdm_requester_get_csr_test_main.
There was a problem hiding this comment.
Thanks. I have moved the code location.
Fix the issue: DMTF#2632 The successful unit_test will always make cached.csr name unchanged. But a failed unit_test may change cached.csr to cached.staging, which cause the next unit_test still failing even if the issue is fixed. Add new api to ensure that cached.csr always exists at the beginning. Signed-off-by: Wenxing Hou <wenxing.hou@intel.com>
Wenxing-hou
force-pushed
the
fix_get_csr_unittest
branch
from
8bd651b
to
7460a81
Compare
steven-bellock
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #2632
The successful unit_test will always make cached.csr name unchanged. But a failed unit_test may change cached.csr to cached.staging, which cause the next unit_test still failing even if the issue is fixed.
Add new api to ensure that cached.csr always exists at the beginning.