Cleanup DOE header #2829
Merged
Cleanup DOE header #2829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyao1
reviewed
Sep 11, 2024
include/industry_standard/pcidoe.h
Outdated
|
|
||
|
|
||
| /* DOE Discovery*/ | ||
| #define PCI_DOE_MAX_SIZE_IN_DW (4 * PCI_DOE_MAX_SIZE_IN_BYTE) |
There was a problem hiding this comment.
This should be (PCI_DOE_MAX_SIZE_IN_BYTE / 4) ?
In particular clarify that the PCIe specification defines the size of a double word as four bytes. Signed-off-by: Steven Bellock <sbellock@nvidia.com>
steven-bellock
force-pushed
the
fix-up-doe
branch
from
ba789e1
to
276bc2d
Compare
twilfredo
approved these changes
Sep 12, 2024
jyao1
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular clarify that the PCIe specification defines the size of a double word as four bytes.
Signed-off-by: Steven Bellock sbellock@nvidia.com