Minor

DMXControl · Oct 2, 2024 · 5ecf37a · 5ecf37a
1 parent 1aabd78
commit 5ecf37a
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/RDMSharp/Metadata/JSON/OneOfTypes/StringType.cs b/RDMSharp/Metadata/JSON/OneOfTypes/StringType.cs
@@ -199,12 +199,12 @@ void parse(Encoding encoder)
                 takenBytesCount = byteLength;
                 charLength = str.Length;
                 bool repeatParse = false;
-                if (MaxLength.HasValue && MaxLength < charLength)
+                if (MaxLength.HasValue && MaxLength.Value < charLength)
                 {
                     charLength = (int)MaxLength.Value;
                     repeatParse = true;
                 }
-                if (MaxBytes.HasValue && MaxBytes < byteLength)
+                if (MaxBytes.HasValue && MaxBytes.Value < byteLength)
                 {
                     byteLength = (int)MaxBytes.Value;
                     repeatParse = true;

diff --git a/RDMSharpTests/Metadata/JSON/TestStringType.cs b/RDMSharpTests/Metadata/JSON/TestStringType.cs
@@ -160,6 +160,15 @@ public void TestParseBadFormatedData1()
             dataTree = stringType.ParseDataToPayload(ref data);
             Assert.That(dataTree.Value, Is.EqualTo(string.Empty));
             Assert.That(dataTree.Issues, Has.Length.EqualTo(1));
+
+            data = new byte[] { 195, 132, 195, 132, 195, 132, 195, 132, 0 };
+            dataTree = stringType.ParseDataToPayload(ref data);
+            Assert.That(dataTree.Value, Is.EqualTo("ÄÄÄÄ"));
+            Assert.That(dataTree.Issues, Has.Length.EqualTo(1));
+            data = new byte[] { 195, 132, 195, 132, 195, 132, 195, 132, 119, 119, 0 };
+            dataTree = stringType.ParseDataToPayload(ref data);
+            Assert.That(dataTree.Value, Is.EqualTo("ÄÄÄÄ"));
+            Assert.That(dataTree.Issues, Has.Length.EqualTo(1));
         }
         [Test]
         public void TestParseBadFormatedData2()